permit specifying trident-operator resources #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netapp-ci-sync
bot
force-pushed
the
master
branch
from
e648ed2 to
1779f49
Compare
clementnuss
force-pushed
the
fix-issue-927
branch
from
4b090f7 to
b8d04d5
Compare
closes NetApp#927 Signed-off-by: Clément Nussbaumer <[email protected]>
|
@vivintw why did you add your commit ? it was breaking the PR. can you consider merging this ? would have been nice to see this happening for the Oct. release, although now I doubt it will be possible |
clementnuss
force-pushed
the
fix-issue-927
branch
from
b8d04d5 to
1f91b26
Compare
|
We get alerts because of the low hardcoded cpu limits since the version 100.2406.1. Merging this would be highly appreciated. |
netapp-ci-sync
bot
force-pushed
the
master
branch
from
5ccfdf7 to
94d0bf7
Compare
|
We're also getting alerts and so really keen to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #927
Change description
Permit specifying the resources of the trident-operator deployment
Did you add unit tests? Why not?
No, minor helm chart modification
Does this code need functional testing?
No, this just moves a configuration to the
.ValuesIs a code review walkthrough needed? why or why not?
No
Does this code need a note in the changelog?
trident operator helm chart: permit specifying trident-operator resources
Additional Information